Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Sep 30, 2025

Description

This PR is the last part of the core data clean-up , where we delete models 1 to 80, proposed on p91TBi-drE-p2

Apologies for the 21k LOC, all of it is model/xcmapping removals and Unit Test updates to account for the minimal model version (80). There are no updates to the migration paths, or any logic has been changed.

Changes:

  • Removed .xcdatamodels from 60 to 79, making the minimum version model 80 (2022-12-15).
  • Removed mapping migrations 74to75
  • Updated unit tests

Testing information

There is no good way to test all the way back to model 80, the more straight-forward to test the migration path is:

  • Delete the app from your device, install the oldest version from TestFlight under Previous builds (22.7 at the moment), and observe that the app does not crash on init.
  • Smoke test a bit, the app should work normally (from my testing the Order list will appear empty, a simple pull-to-refresh should repopulate it, this is expected).

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 30, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added this to the 23.4 milestone Sep 30, 2025
@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Sep 30, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review September 30, 2025 09:51
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16181-99925e6
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commit99925e6
Installation URL5a3m781rsnpk8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma
Copy link
Contributor Author

👋 adding one person from each team just for awareness, one review is enough.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested updating from the oldest test flight and the app works okay. I haven't encountered any crashes or other types of issues.

Thank you for the changes!

@iamgabrielma iamgabrielma merged commit 4053558 into trunk Oct 2, 2025
25 checks passed
@iamgabrielma iamgabrielma deleted the task/WOOMOB-1308-remove-old-cd-models-3 branch October 2, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants