-
Notifications
You must be signed in to change notification settings - Fork 121
[Core Data] Remove old models. Part 3 (60-79) #16181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
|
👋 adding one person from each team just for awareness, one review is enough. |
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Tested updating from the oldest test flight and the app works okay. I haven't encountered any crashes or other types of issues.
Thank you for the changes!

Description
This PR is the last part of the core data clean-up , where we delete models 1 to 80, proposed on p91TBi-drE-p2
Apologies for the 21k LOC, all of it is model/xcmapping removals and Unit Test updates to account for the minimal model version (80). There are no updates to the migration paths, or any logic has been changed.
Changes:
Testing information
There is no good way to test all the way back to model 80, the more straight-forward to test the migration path is:
Previous builds(22.7 at the moment), and observe that the app does not crash on init.